[quote name='e5volcano']How well do these instruments compare to Rock Band ones?[/QUOTE]
I think the general consensus is that the Rock Band 2 drums are superior to the Band Hero drums.
I played with the Band Hero drums a couple of times and found them to be pretty flimsy compared to my Beatles Rock Band Drums. The Hero drums come with cymbals and have 5 different colors. You can buy cymbals for Rock Band 2 drums, but there's only 4 colors (the cymbals repeat colors already on the drums).
Obviously each game is geared toward their particular drums. Hero games will downmix their drum lines to 4 colors to include Rock Band drums, not really sure how Rock Band handles it.
As for guitars, it's more of a matter of personal taste and what guitars you already have. Rock Band guitars tend to be bigger and have the second set of frets. Hero guitars have the strum bar that clicks while Rock Band guitars are quiet. But Band Hero has the GH5 guitar which many people feel is the best guitar in the series.
I'd say it's pretty even, but it comes down to the games you prefer.